Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy protocol decoding and encoding in TCP services #1430

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

jbguerraz
Copy link

Examples:

apiVersion: v1
data:
  "9000": default/http-svc:80:PROXY:PROXY
kind: ConfigMap
metadata:
  name: ingress-controller-tcp
  namespace: kube-system

# TCP services
+    upstream tcp-default-http-svc-80 {
+        server                  172.17.0.3:8080;
+        server                  172.17.0.4:8080;
+    }
+
+    server {
+        listen                  9000 proxy_protocol;
+        listen                  [::]:9000 proxy_protocol;
+        proxy_pass        tcp-default-http-svc-80;
+        proxy_protocol   on;
+    }
apiVersion: v1
data:
  "9000": default/http-svc:80::PROXY
kind: ConfigMap
metadata:
  name: ingress-controller-tcp
  namespace: kube-system

 # TCP services
+    upstream tcp-default-http-svc-80 {
+        server                  172.17.0.3:8080;
+        server                  172.17.0.4:8080;
+    }
+
+    server {
+        listen                  9000;
+        listen                  [::]:9000;
+        proxy_pass        tcp-default-http-svc-80;
+        proxy_protocol   on;
+    }
apiVersion: v1
data:
  "9000": default/http-svc:80:PROXY
kind: ConfigMap
metadata:
  name: ingress-controller-tcp
  namespace: kube-system

# TCP services
+    upstream tcp-default-http-svc-80 {
+        server                  172.17.0.3:8080;
+        server                  172.17.0.4:8080;
+    }
+
+    server {
+        listen                  9000 proxy_protocol;
+        listen                  [::]:9000 proxy_protocol;
+        proxy_pass        tcp-default-http-svc-80;
+    }

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 27, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 43.742% when pulling a24d657 on skilld-labs:proxy-protocol-tcp-upstream into 6e24dc6 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Sep 27, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2017
@aledbf aledbf merged commit ca9a46f into kubernetes:master Sep 27, 2017
@aledbf
Copy link
Member

aledbf commented Sep 27, 2017

@jbguerraz thanks!

@jbguerraz
Copy link
Author

@aledbf you're welcome ! Thank you !

@jbguerraz jbguerraz deleted the proxy-protocol-tcp-upstream branch September 27, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants