Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semicolons in global configuration #1477

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Fix semicolons in global configuration #1477

merged 1 commit into from
Oct 5, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 5, 2017

fixes #1476

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 43.553% when pulling c2a4bbc on aledbf:fix-semicolon into 1c6ff88 on kubernetes:master.

@aledbf aledbf merged commit 23916be into kubernetes:master Oct 5, 2017
@danielfm
Copy link

danielfm commented Oct 5, 2017

Looking forward to a release that includes this fix. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semicolons for global configuration break nginx
5 participants
@aledbf @k8s-reviewable @coveralls @danielfm @k8s-ci-robot