Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test cases for core.pkg.ingress.annotations.cors #154

Merged
merged 1 commit into from
Jan 22, 2017

Conversation

chentao1596
Copy link

Add unit test cases for core.pkg.ingress.annotations.cors, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

annotations map[string]string
expected bool
}{
{map[string]string{"ingress.kubernetes.io/enable-cors": "true"}, true},
Copy link
Member

@aledbf aledbf Jan 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace the keys "ingress.kubernetes.io/enable-cors" with the const annotation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it, PTAL, thank you!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 43.073% when pulling c34f39d on chentao1596:cors-unit-test into 728c1c9 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 43.032% when pulling 4bdc7d8 on chentao1596:cors-unit-test into 728c1c9 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 43.073% when pulling 4bdc7d8 on chentao1596:cors-unit-test into 728c1c9 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jan 22, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2017
@aledbf
Copy link
Member

aledbf commented Jan 22, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit 8f9b710 into kubernetes:master Jan 22, 2017
@chentao1596 chentao1596 deleted the cors-unit-test branch February 10, 2017 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants