Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about proxy_protocol in port 442 #231

Merged
merged 1 commit into from
Feb 5, 2017
Merged

Add information about proxy_protocol in port 442 #231

merged 1 commit into from
Feb 5, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 5, 2017

Adding a comment in the template to avoid adding this directive in the future in the wrong place.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.409% when pulling 36f842c on aledbf:proxy-443 into e35e5bf on kubernetes:master.

@aledbf
Copy link
Member Author

aledbf commented Feb 5, 2017

merging, this is just a comment in the template.

@aledbf aledbf merged commit bf8e2e9 into kubernetes:master Feb 5, 2017
@justinsb
Copy link
Member

justinsb commented Feb 5, 2017

LGTM - nice clarification

gianrubio
gianrubio reviewed Feb 5, 2017
View reviewed changes
Copy link
Contributor

@gianrubio gianrubio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E

@aledbf aledbf deleted the proxy-443 branch February 5, 2017 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianrubio gianrubio gianrubio left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aledbf @k8s-reviewable @coveralls @justinsb @gianrubio @k8s-ci-robot