Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Node StoreLister type #285

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Added a Node StoreLister type #285

merged 1 commit into from
Feb 16, 2017

Conversation

bigkraig
Copy link
Contributor

I'm building an ALB ingress controller that will leverage NodePorts, this was needed to be able to access the EC2 IDs of the nodes.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member

aledbf commented Feb 16, 2017

@bigkraig please sign the cla

@bigkraig
Copy link
Contributor Author

I have just finished signing it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 16, 2017
@aledbf aledbf self-assigned this Feb 16, 2017
@aledbf
Copy link
Member

aledbf commented Feb 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2017
@aledbf
Copy link
Member

aledbf commented Feb 16, 2017

@bigkraig waiting for ci to merge

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 45.626% when pulling 0d05db2 on Ticketmaster:nodelister into b5819d8 on kubernetes:master.

@aledbf aledbf merged commit a41ee3f into kubernetes:master Feb 16, 2017
@aledbf
Copy link
Member

aledbf commented Feb 16, 2017

@bigkraig thanks!

@bigkraig bigkraig deleted the nodelister branch February 16, 2017 17:14
@bprashanth
Copy link
Contributor

@bigkraig nice! I assume you're talking to @justinsb as well since often he has something AWS related in the pipeline for most features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants