Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nginx daemonset example #326

Merged
merged 1 commit into from
Feb 23, 2017
Merged

add nginx daemonset example #326

merged 1 commit into from
Feb 23, 2017

Conversation

chentao1596
Copy link

Add daemonset example, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member

aledbf commented Feb 23, 2017

@chentao1596 please add the example inside a nginx directory ( examples/daemonset/nginx) like the other examples.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.163% when pulling 4954f03 on chentao1596:daemonset into 592814b on kubernetes:master.

@chentao1596 chentao1596 changed the title add daemonset example WIP: add daemonset example Feb 23, 2017
@aledbf aledbf self-assigned this Feb 23, 2017
@aledbf
Copy link
Member

aledbf commented Feb 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2017
@aledbf
Copy link
Member

aledbf commented Feb 23, 2017

@chentao1596 thanks!

@chentao1596 chentao1596 changed the title WIP: add daemonset example add daemonset example Feb 23, 2017
@chentao1596
Copy link
Author

@aledbf It has been modified, thank you for your timely attention!

@chentao1596 chentao1596 changed the title add daemonset example add nginx daemonset example Feb 23, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.163% when pulling e5f6a31 on chentao1596:daemonset into 592814b on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 46.144% when pulling e5f6a31 on chentao1596:daemonset into 592814b on kubernetes:master.

@aledbf aledbf merged commit 2989255 into kubernetes:master Feb 23, 2017
@chentao1596 chentao1596 deleted the daemonset branch February 23, 2017 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chentao1596 @k8s-reviewable @aledbf @coveralls @k8s-ci-robot @chentao11596