-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable custom election id for status sync. #351
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it! |
Nice one! I was just running into this 👍 One small nit: can't we just default the |
@pieterlange Yeah, I also thought about it. But due to the document of nginx-ingress-controller recommends to use kubernetes.io/ingress.class: "nginx" , so I use a new param. But I still think reusing "class" is also fine. |
/lgtm |
@danielqsj thanks! |
What this PR does / why we need it:
Which issue this PR fixes:
Closes #350