Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks if the TLS secret contains a valid keypair structure #358

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Mar 1, 2017

This change checks if the concatenated file with keypair contains the expected keypair structure, with Certificate first and then the Private Key.

This is necessary to avoid errors as reported in issue #242

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2017
@aledbf aledbf self-assigned this Mar 1, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 45.701% when pulling 02fbf00 on rikatz:issue-242 into fb8e2d7 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Mar 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2017
@aledbf aledbf merged commit 3fdb1a8 into kubernetes:master Mar 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@rikatz rikatz deleted the issue-242 branch March 27, 2017 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants