Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ForceSSLRedirect ingress annotation #365

Merged
merged 1 commit into from
Mar 3, 2017
Merged

add ForceSSLRedirect ingress annotation #365

merged 1 commit into from
Mar 3, 2017

Conversation

pwillie
Copy link
Contributor

@pwillie pwillie commented Mar 3, 2017

This PR addresses the HTTPS redirect referenced in #314. Approach is to use an ingress annotation ingress.kubernetes.io/force-ssl-redirect to enable this feature.

fixes #314

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 3, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member

aledbf commented Mar 3, 2017

@pwillie please sign the CLA

@pwillie
Copy link
Contributor Author

pwillie commented Mar 3, 2017

@aledbf done.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 3, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 45.375% when pulling 1a72b3f on pwillie:forcesslredirect into 0b48d3b on kubernetes:master.

@aledbf aledbf self-assigned this Mar 3, 2017
@aledbf
Copy link
Member

aledbf commented Mar 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2017
@aledbf
Copy link
Member

aledbf commented Mar 3, 2017

@pwillie thanks!

@aledbf aledbf merged commit 9f39abc into kubernetes:master Mar 3, 2017
@pwillie pwillie deleted the forcesslredirect branch March 3, 2017 22:00
kdada pushed a commit to caicloud/ingress that referenced this pull request Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nginx] Allow ELB SSL termination with HSTS and HTTPS redirect
5 participants