Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a nil-reference when the temporary file cannot be created #439

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Mar 14, 2017

I hit this one when trying to run the controller outside of kubernetes as per the development documentation. Eventually I gave up on that, but this fix is still valid :)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Mar 14, 2017
@aledbf
Copy link
Member

aledbf commented Mar 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 43.135% when pulling 3dece0a on Collaborne:pr/nil-reference-temp-file into c67e106 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Mar 14, 2017

@ankon thanks!

@aledbf aledbf merged commit 153fdf5 into kubernetes:master Mar 14, 2017
@ankon ankon deleted the pr/nil-reference-temp-file branch March 14, 2017 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants