Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nginx version to one higher than that in contrib #44

Closed
wants to merge 1 commit into from

Conversation

bprashanth
Copy link
Contributor

@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 39.178% when pulling aa70465 on bprashanth:nginx-version into ac6930b on kubernetes:master.

@@ -3,7 +3,7 @@ all: push
BUILDTAGS=

# 0.0 shouldn't clobber any release builds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes this comment stale.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I'm saying 0.0 is unused, or if anything is there it isn't a release build so you can use that tag for testing

@bprashanth
Copy link
Contributor Author

Actually I don't think we're ready to release just yet, this needs more testing according to @aledbf so I'm going to close for now. @r2d4 wdyt about pushing your own till we've had time to validate? we could also do an alpha/beta release, but less work is better :)

@bprashanth bprashanth closed this Dec 7, 2016
@r2d4
Copy link
Contributor

r2d4 commented Dec 7, 2016

@bprashanth SGTM I'll try to get something up later today

haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
* Enable runasnonroot

* fix the copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants