Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about SSL certificates in the default log level. #459

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 16, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.266% when pulling b384a06 on aledbf:log-ssl-information into c25936d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 43.174% when pulling 6fee691 on aledbf:log-ssl-information into a5f8fe2 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 43.163% when pulling 18492c1 on aledbf:log-ssl-information into a5f8fe2 on kubernetes:master.

@aledbf aledbf merged commit 35e4311 into kubernetes:master Mar 17, 2017
s, err = ssl.AddOrUpdateCertAndKey(nsSecName, cert, key, ca)
} else if ca != nil {
glog.V(3).Infof("found only ca.crt, configuring %v as an Certificate Authentication secret", secretName)
glog.Infof("found only ca.crt, configuring %v as an Certificate Authentication secret", secretName)
s, err = ssl.AddCertAuth(nsSecName, ca)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aledbf these lines above log every 10 seconds. Don't know if the whole func shouldn't be running or if the logs shouldn't be as default logs. What about reinclude V() until a correct fix is provided?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if the whole func shouldn't be running or if the logs shouldn't be as default logs

We need to know if there is an issue with the certs. Let me see if I can change this to show only errors in the default level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aledbf Our logs are a bit noisy and I think there is nothing we can do outside Ingress core. Let me know if I can provide some help or if there is a fix in a couple of days. Otherwise no problem! I make a temporary fork and wait the final solution.

@aledbf aledbf deleted the log-ssl-information branch March 27, 2017 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants