Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for CORS on error responses and Authorization header #488

Merged
merged 2 commits into from
Mar 26, 2017
Merged

Adds support for CORS on error responses and Authorization header #488

merged 2 commits into from
Mar 26, 2017

Conversation

canhnt
Copy link
Contributor

@canhnt canhnt commented Mar 23, 2017

  1. This PR supports for CORS error responses, e.g., 4xx or 5xx.

When CORS responses return with error codes, CORS headers are not added properly because 'add_header' directives by default do not add to the response header [1]

[1] http://nginx.org/en/docs/http/ngx_http_headers_module.html#add_header

  1. This PR also supports CORS with 'Authorization' header, which is often used to store JWT token.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 23, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@canhnt
Copy link
Contributor Author

canhnt commented Mar 23, 2017

signed CLA!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 23, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.046% when pulling 46a42a2 on canhnt:master into 116fbe8 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.046% when pulling 46a42a2 on canhnt:master into 116fbe8 on kubernetes:master.

@aledbf aledbf self-assigned this Mar 26, 2017
@aledbf
Copy link
Member

aledbf commented Mar 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2017
@aledbf
Copy link
Member

aledbf commented Mar 26, 2017

@canhnt thanks!

@aledbf aledbf merged commit dfccb44 into kubernetes:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants