Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit test cases for core/pkg/ingress/controller/backend_ssl #536

Merged
merged 2 commits into from
Apr 11, 2017
Merged

add unit test cases for core/pkg/ingress/controller/backend_ssl #536

merged 2 commits into from
Apr 11, 2017

Conversation

chentao1596
Copy link

@chentao1596 chentao1596 commented Apr 1, 2017 •
edited
Loading 

hi, please refer to the description of commits, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf closed this Apr 2, 2017
@aledbf aledbf reopened this Apr 2, 2017
@chentao1596 chentao1596 changed the title add unit test cases for core/pkg/ingress/controller/backend_ssl WIP: add unit test cases for core/pkg/ingress/controller/backend_ssl Apr 5, 2017
@aledbf
Copy link
Member

aledbf commented Apr 5, 2017

@chentao1596 ping. Can you check the error in the tests?

@chentao1596
Copy link
Author

@aledbf ok, i will do it as soon as possible, thank you!

@chentao1596 chentao1596 force-pushed the back_ssl_test branch 4 times, most recently from 0a93677 to 2ec3bb8 Compare April 11, 2017 03:30
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.43% when pulling 2ec3bb8 on chentao1596:back_ssl_test into 6ed6475 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.43% when pulling 2ec3bb8 on chentao1596:back_ssl_test into 6ed6475 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 44.398% when pulling 2ec3bb8 on chentao1596:back_ssl_test into 6ed6475 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.08%) to 45.509% when pulling c92f491 on chentao1596:back_ssl_test into 6ed6475 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.05%) to 45.476% when pulling f5baeb2 on chentao1596:back_ssl_test into 6ed6475 on kubernetes:master.

@chentao1596 chentao1596 changed the title WIP: add unit test cases for core/pkg/ingress/controller/backend_ssl add unit test cases for core/pkg/ingress/controller/backend_ssl Apr 11, 2017
@chentao1596
Copy link
Author

@aledbf hi, i'm sorry for this delay, errors has been resolved, PTAL, thank you!

@aledbf aledbf self-assigned this Apr 11, 2017
@aledbf
Copy link
Member

aledbf commented Apr 11, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2017
@aledbf
Copy link
Member

aledbf commented Apr 11, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit c36d6ff into kubernetes:master Apr 11, 2017
@chentao1596 chentao1596 deleted the back_ssl_test branch April 20, 2017 06:17
@chentao1596 chentao1596 mentioned this pull request Oct 12, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chentao1596 @k8s-reviewable @aledbf @coveralls @k8s-ci-robot @chentao11596