-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build namespace and ingress class as label #551
Conversation
data *vtsData | ||
scrapeChan chan scrapeRequest | ||
ngxHealthPort int | ||
ngxVtsPath, watchNamespace, ingressClass string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please 1 line per attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
data *nginxStatusData | ||
scrapeChan chan scrapeRequest | ||
ngxHealthPort int | ||
ngxVtsPath, watchNamespace, ingressClass string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please 1 attribute per line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
aa8a6de
to
aa72529
Compare
aa72529
to
197acf0
Compare
/lgtm |
@gianrubio can you add an example showing how to set one or more alerts? (not in this PR) |
Sure, I'm working on this :) |
@gianrubio thanks! |
@aledbf I made a mistake when I built the nginx nomenclature. The right way to fill namespace and ingress class is using labels, so it'll easy to filter and reuse.
Old format
New format
Alarm example