Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent misconfiguration of backend.secure and SessionAffinity #560

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

jcmoraisjr
Copy link
Contributor

This PR fixes an intermittent configuration of Backend.Secure and Backend.SessionAffinity if different Ingress configure Secure and SessionAffinity of the same backend with different values. Secure true and AffinityType <> empty-string will always be used if declared.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 44.123% when pulling 4558ef6 on jcmoraisjr:jm-fix-secure-shadow into ed6987e on kubernetes:master.

@aledbf aledbf self-assigned this Apr 6, 2017
@aledbf
Copy link
Member

aledbf commented Apr 6, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2017
@aledbf aledbf merged commit 847c05d into kubernetes:master Apr 6, 2017
@aledbf
Copy link
Member

aledbf commented Apr 6, 2017

@jcmoraisjr thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants