Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed lua_package_path in nginx.tmpl #583

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Conversation

stibi
Copy link
Contributor

@stibi stibi commented Apr 11, 2017

I did my own build of the nginx-ingress-controller and its docker image, but I had troubles with the error_page.lua module, which couldn't be loaded, there was an error in the log, module was not found.

I think the lua package path is wrong, here is a fix.

I did my own build of the nginx-ingress-controller and its docker image, but I had troubles with the `error_page.lua` module, which couldn't be loaded, there was an error in the log, module was not found.

I think the lua package path is wrong, here is a fix.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@stibi
Copy link
Contributor Author

stibi commented Apr 11, 2017

I have signed the CLA now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.43% when pulling beb17f3 on stibi:patch-1 into 6ed6475 on kubernetes:master.

@thelinuxfoundation
Copy link

bump for CLA check

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 12, 2017
@aledbf
Copy link
Member

aledbf commented Apr 12, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2017
@aledbf aledbf merged commit 3810515 into kubernetes:master Apr 12, 2017
@aledbf
Copy link
Member

aledbf commented Apr 12, 2017

@stibi thanks!

@stibi stibi deleted the patch-1 branch April 12, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants