Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hostnames in Ingress status #65

Merged
merged 2 commits into from
Dec 16, 2016
Merged

Support hostnames in Ingress status #65

merged 2 commits into from
Dec 16, 2016

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 16, 2016 •
edited
Loading

In AWS a service with type:Loadbalancer uses a FQDN instead of IPs

fixes #50

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@bprashanth
Copy link
Contributor

LGTM

@bprashanth
Copy link
Contributor

Feel free to merge once travis passes

@bprashanth bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.868% when pulling 77967aa on aledbf:fix-status into e194288 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.868% when pulling 3873042 on aledbf:fix-status into e194288 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.868% when pulling 3873042 on aledbf:fix-status into e194288 on kubernetes:master.

@aledbf aledbf merged commit e58524f into kubernetes:master Dec 16, 2016
@aledbf aledbf deleted the fix-status branch December 21, 2016 00:14
hnrytrn pushed a commit to hnrytrn/ingress-nginx that referenced this pull request Jul 5, 2018
@andrewloux
Merge pull request kubernetes#65 from Shopify/revert-63-new-tmpdir-co…
9a3e787 
…nditionally

Revert "Deterministic temp dir"
haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
@tejohnson123
Fix ssl_certifcate path in nginx-kube.conf for impersonation (#65)
0145166 
The nginx-kube.conf file was hardcoding the name of the ssl secret path
to router_certs.  In 3.2 a new secret name is used.  Modified the code
to use the --default-ssl-certificate parameter for the secret name.
haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
@clyang82
Merge pull request #65 from open-cluster-management/br_add_owners
5935fb1 
Add OWNERS file
@AdrainHuang AdrainHuang mentioned this pull request Apr 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingress only exposes internal node ip
5 participants
@aledbf @k8s-reviewable @bprashanth @coveralls @k8s-ci-robot