Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IP in logs for https traffic #690

Merged
merged 3 commits into from
May 12, 2017
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 5, 2017

No description provided.

@aledbf aledbf self-assigned this May 5, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 47.077% when pulling 7055dc983e65e3f0c199296a7abeb933d374050d on aledbf:avoid-empty-secret into 83d8ba8 on kubernetes:master.

@rikatz
Copy link
Contributor

rikatz commented May 8, 2017

@aledbf The idea here is stop checking every 5 seconds for secrets change (like the messages of secrets that doesn't exists), right?

What's going to be the new approach? Get a secret, and then wait forever until this change?

Thanks!

@aledbf
Copy link
Member Author

aledbf commented May 8, 2017

The idea here is stop checking every 5 seconds for secrets change (like the messages of secrets that doesn't exists), right?

Exactly

What's going to be the new approach? Get a secret, and then wait forever until this change?

Only check after a secret change.

@rikatz
Copy link
Contributor

rikatz commented May 8, 2017

Hum nice!! :D Hope you can achieve this easily :)

May I help you in something?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 46.957% when pulling 5c9c5a3 on aledbf:avoid-empty-secret into c1cf8ff on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 46.931% when pulling a537d2d on aledbf:avoid-empty-secret into 88ca7a5 on kubernetes:master.

@aledbf aledbf changed the title WIP: Avoid periodic check for secret changes Fix IP in logs for https traffic May 12, 2017
@aledbf aledbf merged commit 12d2c4f into kubernetes:master May 12, 2017
@aledbf aledbf deleted the avoid-empty-secret branch May 18, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants