Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for X-Forwarded-For trust #709

Merged
merged 1 commit into from
May 17, 2017
Merged

Conversation

phekmat
Copy link
Contributor

@phekmat phekmat commented May 12, 2017

Use the same config option for set_real_ip_from when not using proxy protocol. The default remains 0.0.0.0/0, which is insecure if the ingress is publicly accessible (or its upstream doesn't strip the X-Forwarded-For header). This at least provides a workaround for #200

Use the same config option for `set_real_ip_from` when not using proxy protocol. The default remains `0.0.0.0/0`, which is insecure if the ingress is publicly accessible. This at least provides a workaround for kubernetes#200
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 12, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@phekmat
Copy link
Contributor Author

phekmat commented May 12, 2017

CLA should be signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 12, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 46.953% when pulling dd894f0 on phekmat:patch-1 into 88ca7a5 on kubernetes:master.

@aledbf aledbf self-assigned this May 17, 2017
@aledbf
Copy link
Member

aledbf commented May 17, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2017
@aledbf
Copy link
Member

aledbf commented May 17, 2017

@phekmat thanks!

@aledbf aledbf merged commit c831359 into kubernetes:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants