Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected annotation ex signin-url to auth-url #715

Merged
merged 1 commit into from
May 14, 2017
Merged

Corrected annotation ex signin-url to auth-url #715

merged 1 commit into from
May 14, 2017

Conversation

olvesh
Copy link
Contributor

@olvesh olvesh commented May 14, 2017

Example was wrong, had to dig through code to find the correct annotation.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this May 14, 2017
@aledbf
Copy link
Member

aledbf commented May 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2017
@aledbf
Copy link
Member

aledbf commented May 14, 2017

@olvesh thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 46.901% when pulling 4e94069 on olvesh:master into 37abed3 on kubernetes:master.

@aledbf aledbf merged commit 07647fd into kubernetes:master May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olvesh @k8s-reviewable @aledbf @coveralls @k8s-ci-robot