Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic variable name #809

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 2, 2017

This change is required to avoid long nginx variables names and avoid issues with the vairable bucket size setting.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf force-pushed the fix-variables-map branch from 1b68f42 to 6278021 Compare June 2, 2017 14:22
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 46.482% when pulling 62780210f4d2ce7f37a0711cdb9fa2310971aea5 on aledbf:fix-variables-map into f148465 on kubernetes:master.

@aledbf aledbf force-pushed the fix-variables-map branch from 6278021 to b70e9ca Compare June 2, 2017 15:12
@aledbf aledbf changed the title WIP: Fix dynamic variable name Fix dynamic variable name Jun 2, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 46.491% when pulling b70e9ca on aledbf:fix-variables-map into f148465 on kubernetes:master.

@aledbf aledbf merged commit 66b4c26 into kubernetes:master Jun 2, 2017
@aledbf aledbf deleted the fix-variables-map branch June 6, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants