Do not push containers to remote repo as part of test-e2e. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the cluster runs locally, this seems unnecessary.
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
hnrytrn
pushed a commit
to hnrytrn/ingress-nginx
that referenced
this pull request
Aug 9, 2018
remove unnecessary changes
haoqing0110
referenced
this pull request
in stolostron/management-ingress
Mar 5, 2021
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Dec 29, 2023
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Aug 14, 2024
Remove test step from our CI because it runs the upstream's e2e Go tests incorrectly and fails. Since we don't have any tests of our own, and upstream's CI already runs these tests, this step can be removed. removed drone ci add drone's build and validate job in github actions workflow add release workflow which will run only while tagging added git in workflow steps for build and release remove G109 check till gosec resolves issues revert back PR kubernetes#81 remove depreview action use rancher's repository image Add arm and s390x in the arches in scripts/build. only amd64 and arm64 was in arches because of this the CI wasn't able to find the following files with not found error. /bin/arm/nginx-ingress-controller, /bin/arm/wait-shutdown and /bin/arm/dbg remove the upstream's workflow Remove Drone CI file Add Rancher's workflow files add the workflow for FOSSA
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Aug 20, 2024
Remove test step from our CI because it runs the upstream's e2e Go tests incorrectly and fails. Since we don't have any tests of our own, and upstream's CI already runs these tests, this step can be removed. removed drone ci add drone's build and validate job in github actions workflow add release workflow which will run only while tagging added git in workflow steps for build and release remove G109 check till gosec resolves issues revert back PR kubernetes#81 remove depreview action use rancher's repository image Add arm and s390x in the arches in scripts/build. only amd64 and arm64 was in arches because of this the CI wasn't able to find the following files with not found error. /bin/arm/nginx-ingress-controller, /bin/arm/wait-shutdown and /bin/arm/dbg remove the upstream's workflow Remove Drone CI file Add Rancher's workflow files add the workflow for FOSSA
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Aug 20, 2024
Remove test step from our CI because it runs the upstream's e2e Go tests incorrectly and fails. Since we don't have any tests of our own, and upstream's CI already runs these tests, this step can be removed. removed drone ci add drone's build and validate job in github actions workflow add release workflow which will run only while tagging added git in workflow steps for build and release remove G109 check till gosec resolves issues revert back PR kubernetes#81 remove depreview action use rancher's repository image Add arm and s390x in the arches in scripts/build. only amd64 and arm64 was in arches because of this the CI wasn't able to find the following files with not found error. /bin/arm/nginx-ingress-controller, /bin/arm/wait-shutdown and /bin/arm/dbg remove the upstream's workflow Remove Drone CI file Add Rancher's workflow files add the workflow for FOSSA
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Aug 20, 2024
remove the upstream's workflow Add arm and s390x in the arches in scripts/build. only amd64 and arm64 was in arches because of this the CI wasn't able to find the following files with not found error. /bin/arm/nginx-ingress-controller, /bin/arm/wait-shutdown and /bin/arm/dbg fix drone build failure `go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569 use rancher's repository image remove depreview action revert back PR kubernetes#81 removed drone ci add drone's build and validate job in github actions workflow add release workflow which will run only while tagging added git in workflow steps for build and release remove G109 check till gosec resolves issues Remove test step from our CI Remove test step from our CI because it runs the upstream's e2e Go tests incorrectly and fails. Since we don't have any tests of our own, and upstream's CI already runs these tests, this step can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the cluster runs locally, this seems unnecessary.
Fixes #79.