Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create or delete ingress based on class annotation #825

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Create or delete ingress based on class annotation #825

merged 1 commit into from
Jun 7, 2017

Conversation

jcmoraisjr
Copy link
Contributor

This PR fixes the removing or reincluding ingress resource when the ingress class annotation changes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Jun 7, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 46.45% when pulling 6b54ae5 on jcmoraisjr:jm-edit-ingclass into 8cd9a5a on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jun 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2017
@aledbf
Copy link
Member

aledbf commented Jun 7, 2017

@jcmoraisjr thanks!

@aledbf aledbf merged commit d556cc0 into kubernetes:master Jun 7, 2017
@jcmoraisjr jcmoraisjr deleted the jm-edit-ingclass branch June 7, 2017 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcmoraisjr @k8s-reviewable @coveralls @aledbf @k8s-ci-robot