Update X-Forwarded-Port #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
alexw23
commented
Dec 22, 2016
| @@ -197,7 +202,7 @@ http { | |||
| {{ end }} | |||
|
|
|||
| # map port 442 to 443 for header X-Forwarded-Port | |||
| map $pass_port $server_port { | |||
| map $pass_port $pass_server_port { | |||
There was a problem hiding this comment.
I wasn't sure about this 442 to 443 entry so I left it as is.
aledbf
suggested changes
Dec 23, 2016
| @@ -107,6 +107,11 @@ http { | |||
| default $http_x_forwarded_proto; | |||
| '' $scheme; | |||
| } | |||
|
|
|||
| map $http_x_forwarded_proto $pass_server_port { | |||
There was a problem hiding this comment.
you mean http_x_forwarded_port right?
There was a problem hiding this comment.
Yes sorry - I edited it on the fly.
|
fixed by #91 |
hnrytrn
pushed a commit
to hnrytrn/ingress-nginx
that referenced
this pull request
Aug 9, 2018
Flush queue periodically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears this package is assuming the port running on the Ingress Controller as the port.
In the current situation, if my LB sends X-Forwarded-Port: 443 and the ingress controller is running on port 80. X-Forwarded-Port: 80 will end up in my app.
Now it's correctly routing.