Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the wrong links to the examples and developer documentation #89

Merged
merged 1 commit into from
Dec 26, 2016

Conversation

chentao1596
Copy link

Fix the wrong links to the "examples" and "developer documentation" in the file "README.md", thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 26, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 39.823% when pulling fa608dd on chentao1596:fix-develop-guide-ref into 3980756 on kubernetes:master.

@aledbf aledbf self-assigned this Dec 26, 2016
@aledbf
Copy link
Member

aledbf commented Dec 26, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2016
@aledbf aledbf merged commit bd64dd5 into kubernetes:master Dec 26, 2016
@chentao1596 chentao1596 deleted the fix-develop-guide-ref branch December 26, 2016 13:30
@perrefe
Copy link

perrefe commented Feb 23, 2017

In Deployment section, there is a reference to examples/default/rc-default.yaml ingress controller spec, but it is not in the repository.

@chentao1596
Copy link
Author

According to my understand, we should modify them to the correct positions in the current repository. I advise to open an new issue if not sure, it should be a good method to help to resolve this confusion, thank you!

hnrytrn pushed a commit to hnrytrn/ingress-nginx that referenced this pull request Aug 9, 2018
haoqing0110 pushed a commit to stolostron/management-ingress that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants