Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nginx version to 1.13.3 to fix integer overflow #949

Merged
merged 1 commit into from
Jul 12, 2017
Merged

fix nginx version to 1.13.3 to fix integer overflow #949

merged 1 commit into from
Jul 12, 2017

Conversation

RemingtonReackhof
Copy link
Contributor

Due to http://nginx.org/en/security_advisories.html

This increases the version of nginx to 1.13.3

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member

aledbf commented Jul 11, 2017

@RemingtonReackhof you need to update the sha256 https://github.com/RemingtonReackhof/ingress/blob/master/images/nginx-slim/build.sh#L80

@aledbf
Copy link
Member

aledbf commented Jul 11, 2017

also you need to update https://github.com/kubernetes/ingress/blob/master/images/nginx-slim/Makefile#L16 to 0.21

@aledbf aledbf self-assigned this Jul 11, 2017
@RemingtonReackhof
Copy link
Contributor Author

@aledbf should be set now

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 44.328% when pulling 53b8369 on RemingtonReackhof:update-nginx-version into 26fccdc on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.342% when pulling 53b8369 on RemingtonReackhof:update-nginx-version into 26fccdc on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jul 12, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2017
@aledbf
Copy link
Member

aledbf commented Jul 12, 2017

@RemingtonReackhof thanks

@aledbf
Copy link
Member

aledbf commented Jul 12, 2017

I will open a PR to update the ubuntu-slim image and then we can release this update

@aledbf aledbf merged commit eb5a530 into kubernetes:master Jul 12, 2017
@RemingtonReackhof RemingtonReackhof deleted the update-nginx-version branch July 13, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RemingtonReackhof @k8s-reviewable @aledbf @coveralls @k8s-ci-robot