Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo PassthrougBackends -> PassthroughBackends #96

Merged
merged 1 commit into from
Dec 29, 2016
Merged

Fix typo PassthrougBackends -> PassthroughBackends #96

merged 1 commit into from
Dec 29, 2016

Conversation

justinsb
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Dec 29, 2016
@aledbf
Copy link
Member

aledbf commented Dec 29, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2016
@justinsb
Copy link
Member Author

Not sure if we have to keep the typo for backcompat - in case someone is using it in a custom template?

@aledbf
Copy link
Member

aledbf commented Dec 29, 2016

Not sure if we have to keep the typo for backcompat - in case someone is using it in a custom template?

No because there's no release from this repo yet.

@justinsb
Copy link
Member Author

Thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 39.815% when pulling fb8208c on justinsb:fix_typo into 8e90fc0 on kubernetes:master.

@aledbf aledbf merged commit 756b41b into kubernetes:master Dec 29, 2016
hnrytrn pushed a commit to hnrytrn/ingress-nginx that referenced this pull request Aug 9, 2018
@ElvinEfendi
Merge pull request kubernetes#96 from Shopify/sync-upstream
534b5e2 
Sync upstream
haoqing0110 pushed a commit to stolostron/management-ingress that referenced this pull request Mar 5, 2021
@AnitaNayak
Updated Dockerfile.s390x (kubernetes#96)
975fff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justinsb @k8s-reviewable @aledbf @coveralls @k8s-ci-robot