Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: CoreDNS CoreFile fully configurable #7347

Closed
gjtempleton opened this issue Jul 31, 2019 · 0 comments · Fixed by #7376
Closed

Feature Request: CoreDNS CoreFile fully configurable #7347

gjtempleton opened this issue Jul 31, 2019 · 0 comments · Fixed by #7376

Comments

@gjtempleton
Copy link
Member

gjtempleton commented Jul 31, 2019

1. Describe IN DETAIL the feature/behavior/change you would like to see.
The provided CoreDNS config/CoreFile is nice however not very flexible. We currently use a fairly customised CoreFile internally and use a

kubeDNS:
    provider: External

stanza to allow us to deploy our own CoreDNS setup. There's at least one PR already aiming at extending the flexibility of this setup: #5839 however we'd like to go the whole hog and allow users to provide a full string for the coreFile which would then be inserted here: https://github.com/kubernetes/kops/blob/master/upup/models/cloudup/resources/addons/coredns.addons.k8s.io/k8s-1.6.yaml.template#L61
maintaining the existing behaviour otherwise.

Example config as imagined:

kubeDNS:
    provider: CoreDNS
    coreFileContents: |
        amazonaws.com:53 {
            errors
            log . {
                class denial error
            }
            health :8084
            prometheus :9153
            proxy . 169.254.169.253 {
            }
            cache 30
        }
        .:53 {
            errors
            health :8080
            autopath @kubernetes
            kubernetes cluster.local {
                pods verified
                upstream 169.254.169.253
                fallthrough in-addr.arpa ip6.arpa
            }
            prometheus :9153
            proxy . 169.254.169.253
            cache 300
        }

Obviously this would have to come with big warnings that no compatibility guarantees could be maintained on changing kops versions potentially changing CoreDNS compatibility so I would imagine also offering configurability of the CoreDNS image used at the same time (the PR mentioned above already provides this) to allow users to ensure they don't unexpectedly jump versions and find their CoreFile suddenly becoming invalid.

2. Feel free to provide a design supporting your feature request.
N/A for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant