-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support verticalpodautoscaler v1 #1718
Comments
@fpetkovski, is this something to be looked into or would the quote below from the README negate this issue?
I'm not too familiar with the compatibility and versioning of KSM. The quote says "will only use the oldest API available in the latest release", what does this mean exactly? Would this mean if |
KSM aims to have backwards compatibility with the latest 3 Kubernetes versions. However, VPA is an external CRD so I'm not sure if we should apply the same rules since the CRD is not linked to Kubernetes releases. I think it should be safe to switch to @mrueg @dgrisonnet any thoughts from your side? |
Adding VPA to kube-state-metrics was a mistake since it is out of its scope to only expose metrics about the core resources of Kubernetes. This leads to the problem we have here where we can't really move forward with an update since the API isn't tied to Kubernetes directly. In my opinion, we should slowly deprecate it in favor of adding it as a configuration-based CRD. In the meantime, I think we shouldn't break the existing compatibility and stick to v1beta2. As for the deprecation of VPA, I would recommend doing it over 2 minor releases of ksm: v2.6.0:
v2.8.0:
|
I think this makes sense. Now that we have a way to export metrics from CR fields, we can start deprecating the built-in VPA support. |
Should we plan work on this for v3? I think there are a couple of larger changes that we might want to include (e.g. Refactor command line arguments, remove specific metrics, rename others, etc.) |
We could mark VPA as deprecated in 2.6 and advise users to use CRD metrics. I would say the removal of the feature should happen in v3 at the latest, but I am also fine with having it in a 2.x release in case someone has time to do the work. |
I agree with Filip, we shouldn't necessarily wait for 3.x to remove the metrics since we have a way to deprecate them now. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Did anyone manage to create the CustomResourceState configuration that provides the same metrics? I'm new to Custom Resource State but creating the removed metrics seems like a not so easy topic |
@mrueg wrote this doc https://github.com/kubernetes/kube-state-metrics/blob/main/docs/customresourcestate-metrics.md#verticalpodautoscaler to migrate VPA to CustomResourceState. It might be worth extending it to include all the VPA metrics that are going to be removed. |
I'd love to do it but i'm not sure how to get the metrics coming from Kubernetes resource list like:
The 2 issues I had were: |
Quantile/Percentage support is in the main branch and will be shipped with v2.9.0: #1989 I would suggest to open a new issue about the missing "complete replacement config for VPA in CRM" and continue the conversation there. |
Added the request #2041 :) |
What would you like to be added:
Support verticalpodautoscalers/v1
Why is this needed:
Since vertical pod autoscalers CRD has been updated from v1beta2 to v1, kube-state-metrics should support new version of API. (release note)
Describe the solution you'd like
Generate client codes from version
v1
and modify the dependencies.The legacy client dependency is
v1beta2
, below is one of them I found.kube-state-metrics/internal/store/builder.go
Line 38 in 41eea36
Additional context
The text was updated successfully, but these errors were encountered: