Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version is not applied to the container release binary #2455

Closed
mrueg opened this issue Jul 25, 2024 · 2 comments · Fixed by #2456
Closed

Version is not applied to the container release binary #2455

mrueg opened this issue Jul 25, 2024 · 2 comments · Fixed by #2456
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@mrueg
Copy link
Member

mrueg commented Jul 25, 2024

What happened:
https://github.com/kubernetes/kube-state-metrics/pull/2361/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R5 requires gomplate to be installed to read the version.

The Dockerfile currently does not run make install-tools to install gomplate
What you expected to happen:
We should install them during the build process in the Dockerfile to ensure that the version is correctly read.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
See: https://kubernetes.slack.com/archives/CJJ529RUY/p1721936633731669
Environment:

  • kube-state-metrics version: v2.12.0+
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Other info:

CC: @Pokom

@mrueg mrueg added the kind/bug Categorizes issue or PR as related to a bug. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 25, 2024
@mrueg mrueg self-assigned this Jul 25, 2024
@Pokom
Copy link
Contributor

Pokom commented Jul 25, 2024

Thanks for filing the issue @mrueg! Do you need any helping on crafting a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants