Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt pod checkpointer #131

Closed
pires opened this issue Jan 23, 2017 · 16 comments
Closed

Adopt pod checkpointer #131

pires opened this issue Jan 23, 2017 · 16 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triaged
Milestone

Comments

@pires
Copy link
Contributor

pires commented Jan 23, 2017

Refs #127

@luxas
Copy link
Member

luxas commented Feb 9, 2017

This task includes:

@luxas luxas added this to the v1.6 milestone Feb 9, 2017
@errordeveloper
Copy link
Member

I am somewhat reluctant to moving the moving the code without making any use of it, what is the follow up accomplishment? If we are not so sure, may be we shouldn't do it until we are sure.

@luxas
Copy link
Member

luxas commented Feb 10, 2017

First, move the code to kubernetes/kubeadm, and once we have the Makefile as well, @mikedanese will push the Docker image with that checkpointer inside and then we'll deploy it when using selfhosting and kuebadm.

@pires
Copy link
Contributor Author

pires commented Feb 10, 2017

Also @aaronlevy mentioned that when this move is done, bootkube would be changed to use the upstream (this!) solution.

@luxas
Copy link
Member

luxas commented Feb 10, 2017

Exactly! Both can take advantage of and experiment with it!

@aaronlevy
Copy link

What is the process for getting images built? That would be my only concern moving bootkube over (e.g. needing a fix but not being able to get an image built). But I don't want to have to manage changes between the code in two places - so ideally can move over to a single source of truth quickly.

@luxas
Copy link
Member

luxas commented Feb 10, 2017

That can be a bottleneck frankly, since Googlers only have push access to gcr.io
But maybe @mikedanese can promise to push images quickly if there have been changes committed ;)

@luxas luxas removed this from the v1.6 milestone Mar 2, 2017
@luxas luxas added area/self-hosting priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 29, 2017
@luxas luxas added this to the v1.8 milestone May 29, 2017
@luxas
Copy link
Member

luxas commented Aug 19, 2017

@timothysc is working on implementing this; it's tracked in a features issue as well: kubernetes/enhancements#378

@luxas
Copy link
Member

luxas commented Sep 6, 2017

@timothysc I'm moving this to v1.9

@luxas luxas modified the milestones: v1.9, v1.8 Sep 6, 2017
@luxas
Copy link
Member

luxas commented Nov 22, 2017

@timothysc we need to annotate the control plane manifests with the magic annotation if the self-hosting feature gate is set now, right?

@timothysc
Copy link
Member

yes, add node.kubernetes.io/bootstrap-checkpoint=true

@timothysc
Copy link
Member

complete details are here - https://github.com/kubernetes/community/pull/1241/files

@jberkus
Copy link

jberkus commented Dec 1, 2017

This issue is listed as being in 1.9, can we have a status? It appears that there hasn't been any work on it in a while.

@luxas
Copy link
Member

luxas commented Dec 11, 2017

Moved to v1.10 as discussed in the SIG

@luxas luxas modified the milestones: v1.9, v1.10 Dec 11, 2017
@timothysc timothysc added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 24, 2018
@timothysc timothysc modified the milestones: v1.10, v1.11 Jan 24, 2018
@timothysc
Copy link
Member

@errordeveloper was going to re-look into the secrets issues and the multiple approaches.

@timothysc
Copy link
Member

Closing, I have cleaner plans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triaged
Projects
None yet
Development

No branches or pull requests

6 participants