Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm join should support kubelet component config #2008

Closed
BenTheElder opened this issue Jan 22, 2020 · 2 comments
Closed

kubeadm join should support kubelet component config #2008

BenTheElder opened this issue Jan 22, 2020 · 2 comments

Comments

@BenTheElder
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?

Choose one: BUG REPORT or FEATURE REQUEST

As far as I can tell KubeletConfiguration while advertised in the kubeadm config docs is not respected during kubeadm join --config, which means we must instead configure kubelet via flags in kubeadm's JoinConfiguration.NodeRegistration.KubeletExtraArgs. This is less than ideal because kubelet flags are often deprecated in favor of the component config fields and we have no way to configure these for nodes via kubeadm.

Ideally specifying a KubeletConfiguration object would work in kubeadm init and kubeadm join via --config, but I'm not sure what happens there yet or what exactly is involved to change this.

kubernetes-sigs/kind#1270


Versions

kubeadm version (use kubeadm version): kubeadm version: &version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2020-01-14T00:08:27Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}

Environment:

  • Kubernetes version (use kubectl version): $ kubectl version Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.1", GitCommit:"d224476cd0730baca2b6e357d144171ed74192d6", GitTreeState:"clean", BuildDate:"2020-01-14T21:04:32Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2020-01-14T00:09:19Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
  • Cloud provider or hardware configuration: kind
  • OS (e.g. from /etc/os-release): ~ubuntu
  • Kernel (e.g. uname -a): 5.2.17
  • Others:
@neolit123
Copy link
Member

duplicate of #1682

@BenTheElder
Copy link
Member Author

thanks! I didn't find that one searching, sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants