Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--service-cidr option should set DNS server IP #83

Closed
bronger opened this issue Dec 5, 2016 · 2 comments
Closed

--service-cidr option should set DNS server IP #83

bronger opened this issue Dec 5, 2016 · 2 comments

Comments

@bronger
Copy link

bronger commented Dec 5, 2016

According to http://kubernetes.io/docs/admin/kubeadm/, if you pass the --service-cidr option, “you will also need to update the /etc/systemd/system/kubelet.service.d/10-kubeadm.conf file to reflect this change else DNS will not function correctly”. Indeed, my tests show that the DNS server IP in that file must be within the given service network.

I think kubeadm should patch the configuration file and reload/restart the service if --service-cidr is given. The current approach is awkward and error-prone.

@pires
Copy link
Contributor

pires commented Jan 10, 2017

@luxas another use case for templates?

@luxas
Copy link
Member

luxas commented Jan 10, 2017

@pires This is not related to using go templates for the kube-dns deployment, it's about configuring kubelet flags IIUC

We are totally aware of this and that's one of the reasons kubeadm is in alpha.
We're not gonna start patching service files on the host, that's a total no-no and will be completely unmaintainable if we would go down that road.

Instead we want to use Kubelet Dynamic Settings #28 that can do this for us. The problem is that the feature isn't done in the core and we're stalled by that unless we build a custom controller that configures the controllers.

Please read about Kubelet Dynamic Settings so you see what it can and will do.
I'm closing this as a dupe of #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants