Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add last start (verbose) logs to minikube logs command #10336

Closed
spowelljr opened this issue Feb 1, 2021 · 5 comments
Closed

Add last start (verbose) logs to minikube logs command #10336

spowelljr opened this issue Feb 1, 2021 · 5 comments
Assignees
@spowelljr
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.18.0

Comments

@spowelljr
Copy link
Member

No description provided.

@spowelljr spowelljr added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 1, 2021
@spowelljr spowelljr added this to the v1.18.0 milestone Feb 1, 2021
@spowelljr spowelljr self-assigned this Feb 1, 2021
@priyawadhwa priyawadhwa added kind/support Categorizes issue or PR as a support question. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/support Categorizes issue or PR as a support question. labels Feb 3, 2021
@spowelljr
Copy link
Member Author

In-progress

@spowelljr spowelljr mentioned this issue Feb 13, 2021
Merged
@spowelljr
Copy link
Member Author

Discovered that if the .minikube dir doesn't exist, fails to write file. Needs to create home dir if detected it doesn't exist.

@spowelljr
Copy link
Member Author

Fixed adding log dir if it doesn't exist, however fails on delete --purge because dir exists on check but it's deleted when it goes to log, need to skip logging if dir doesn't exist or detect if delete --purge.

@spowelljr
Copy link
Member Author

The above comment is actually an audit.json issue, and not related to start logs.

@spowelljr
Copy link
Member Author

Need to make minikube logs display a nice message instead of erroring if no lastStart.txt file exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spowelljr spowelljr

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.18.0
Development

No branches or pull requests
2 participants
@priyawadhwa @spowelljr