-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: make it hard to miss Important notices #10781
Comments
I support making important notes more obvious, but just as an aside, the sentence "Registry addon on with docker uses 55012 please use that instead of default 5000." is wildly unclear. 5000 of what? |
It should probably at least say "port 5000", maybe even give an example. |
Or you could go to town and use: https://github.com/Delta456/box-cli-maker MINIKUBE_IN_STYLE=true
MINIKUBE_IN_STYLE=false
EDIT: I added the missing "port" and "driver", there was an extra "on" in the sentence as well See 5cf8dce#diff-674f8712fba78241aab11240ee7ca41ccfb04fc933ac5fcf9da37f0256e5adc7 |
Even more aside, this "insecure registry" hack with localhost:5000 is getting old... One of these days, we would have to deploy a real registry with real certificates ? https://docs.docker.com/registry/deploying/#run-an-externally-accessible-registry See #10780 (comment) Until then, there is That will use ssh to talk to the nodes, so it doesn't need this http-on-port-5000 hack. |
@afbjorklund I like the box idea, we could add it for the Exit with Advcice too for example in this UI, it is easy to miss the "Suggestion" without a box
|
I noticed many ppl miss the notice to use different Port for Mac Os for registry addon
maybe we can have a new style that creates a Index Pointer Emoji in a Box with one line empty above and bellow so it is hard to miss
The text was updated successfully, but these errors were encountered: