Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: make it hard to miss Important notices #10781

Closed
medyagh opened this issue Mar 10, 2021 · 5 comments · Fixed by #10818
Closed

UI: make it hard to miss Important notices #10781

medyagh opened this issue Mar 10, 2021 · 5 comments · Fixed by #10818
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/ux priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 10, 2021

I noticed many ppl miss the notice to use different Port for Mac Os for registry addon

$ minikube addons enable registry
💡  Registry addon on with docker uses 55012 please use that instead of default 5000
📘  For more information see: https://minikube.sigs.k8s.io/docs/drivers/docker
    ▪ Using image registry:2.7.1
    ▪ Using image gcr.io/google_containers/kube-registry-proxy:0.4
🔎  Verifying registry addon...
🌟  The 'registry' addon is enabled

maybe we can have a new style that creates a Index Pointer Emoji in a Box with one line empty above and bellow so it is hard to miss

$ minikube addons enable registry
👉  ------------------------------------------------------------------------------------------
👉   Registry addon on with docker uses 55012 please use that instead of default 5000.   
👉  ------------------------------------------------------------------------------------------
📘  For more information see: https://minikube.sigs.k8s.io/docs/drivers/docker
    ▪ Using image registry:2.7.1
    ▪ Using image gcr.io/google_containers/kube-registry-proxy:0.4
🔎  Verifying registry addon...
🌟  The 'registry' addon is enabled
@medyagh medyagh added the triage/discuss Items for discussion label Mar 10, 2021
@sharifelgamal
Copy link
Collaborator

I support making important notes more obvious, but just as an aside, the sentence "Registry addon on with docker uses 55012 please use that instead of default 5000." is wildly unclear. 5000 of what?

@afbjorklund
Copy link
Collaborator

afbjorklund commented Mar 14, 2021

I support making important notes more obvious, but just as an aside, the sentence "Registry addon on with docker uses 55012 please use that instead of default 5000." is wildly unclear. 5000 of what?

It should probably at least say "port 5000", maybe even give an example.

https://docs.docker.com/registry/deploying/

@afbjorklund
Copy link
Collaborator

afbjorklund commented Mar 14, 2021

a Box with one line empty above and bellow so it is hard to miss

Or you could go to town and use: https://github.com/Delta456/box-cli-maker

registry-box-cli

MINIKUBE_IN_STYLE=true

    ╭──────────────────────────────────────────────────────────────────────────────────────────╮
💡  │Registry addon on with docker uses port 49170 please use that instead of default port 5000│
    │                                                                                          │
    ╰──────────────────────────────────────────────────────────────────────────────────────────╯
📘  For more information see: https://minikube.sigs.k8s.io/docs/drivers/docker
    ▪ Using image registry:2.7.1
    ▪ Using image gcr.io/google_containers/kube-registry-proxy:0.4
🔎  Verifying registry addon...
🌟  The 'registry' addon is enabled

MINIKUBE_IN_STYLE=false

  ╭──────────────────────────────────────────────────────────────────────────────────────────╮
* │Registry addon on with docker uses port 49170 please use that instead of default port 5000│
  │                                                                                          │
  ╰──────────────────────────────────────────────────────────────────────────────────────────╯
* For more information see: https://minikube.sigs.k8s.io/docs/drivers/docker
  - Using image registry:2.7.1
  - Using image gcr.io/google_containers/kube-registry-proxy:0.4
* Verifying registry addon...
* The 'registry' addon is enabled

EDIT: I added the missing "port" and "driver", there was an extra "on" in the sentence as well

See 5cf8dce#diff-674f8712fba78241aab11240ee7ca41ccfb04fc933ac5fcf9da37f0256e5adc7

@afbjorklund
Copy link
Collaborator

afbjorklund commented Mar 14, 2021

Even more aside, this "insecure registry" hack with localhost:5000 is getting old...

One of these days, we would have to deploy a real registry with real certificates ?

https://docs.docker.com/registry/deploying/#run-an-externally-accessible-registry

See #10780 (comment)

Until then, there is minikube image for all your container runtime image needs.

That will use ssh to talk to the nodes, so it doesn't need this http-on-port-5000 hack.

@medyagh medyagh added kind/feature Categorizes issue or PR as related to a new feature. and removed triage/discuss Items for discussion labels Mar 15, 2021
@medyagh
Copy link
Member Author

medyagh commented Mar 15, 2021

@afbjorklund I like the box idea, we could add it for the Exit with Advcice too

for example in this UI, it is easy to miss the "Suggestion" without a box

$ make && mk start --driver=docker
go build  -tags "" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.18.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.18.0-1615350772-10704 -X k8s.io/minikube/pkg/version.gitCommitID="ff0e25ada888cf1bd7b262857ce96531c1231e69-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v4" -o out/minikube k8s.io/minikube/cmd/minikube
😄  minikube v1.18.1 on Darwin 11.2.3
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
✋  Stopping node "minikube"  ...
🛑  Powering off "minikube" via SSH ...
🔥  Deleting "minikube" in docker ...
🤦  StartHost failed, but will try again: creating host: create: creating: prepare kic ssh: copying pub key: docker copy /var/folders/s8/wxxccj3x7mncysv_zzm5w_r400h78j/T/tmpf-memory-asset265183811 into minikube:/home/docker/.ssh/authorized_keys, output: lstat /private/var/folders/s8/wxxccj3x7mncysv_zzm5w_r400h78j/T/tmpf-memory-asset265183811: no such file or directory
: exit status 1
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
😿  Failed to start docker container. Running "minikube delete" may fix it: creating host: create: creating: prepare kic ssh: copying pub key: docker copy /var/folders/s8/wxxccj3x7mncysv_zzm5w_r400h78j/T/tmpf-memory-asset091998406 into minikube:/home/docker/.ssh/authorized_keys, output: lstat /private/var/folders/s8/wxxccj3x7mncysv_zzm5w_r400h78j/T/tmpf-memory-asset091998406: no such file or directory
: exit status 1

❌  Exiting due to GUEST_KIC_CP_PUBKEY: Failed to start host: creating host: create: creating: prepare kic ssh: copying pub key: docker copy /var/folders/s8/wxxccj3x7mncysv_zzm5w_r400h78j/T/tmpf-memory-asset091998406 into minikube:/home/docker/.ssh/authorized_keys, output: lstat /private/var/folders/s8/wxxccj3x7mncysv_zzm5w_r400h78j/T/tmpf-memory-asset091998406: no such file or directory
: exit status 1
💡  Suggestion: Ensure the tmp directory path is writable to the current user.
🍿  Related issue: https://github.com/kubernetes/minikube/issues/10772

@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/ux priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants