Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set a mirror for downloading kubectl, kubelet, & kubeadm #11935

Closed
bodgit opened this issue Jul 8, 2021 · 4 comments · Fixed by #12804
Closed

Ability to set a mirror for downloading kubectl, kubelet, & kubeadm #11935

bodgit opened this issue Jul 8, 2021 · 4 comments · Fixed by #12804
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@bodgit
Copy link
Contributor

bodgit commented Jul 8, 2021

This is partly related to #11934 in that I'm trying to get minikube to work in an offline environment, or at least without direct internet connectivity. I have Artifactory configured as a Docker registry so assuming that issue is fixed, I don't need direct internet access to download the container images.

However minikube still needs internet access to download the three kube* binaries. If I configure proxy access then there's nothing really to stop the container images being pulled through the proxy as well, which I'd like to avoid as it circumvents our internal policies and checks. It would be handy if I could supply an alternative URL that could be used to download the three kube* binaries. I can then set up an internal mirror of the https://storage.googleapis.com/kubernetes-release/release/* content.

Steps to reproduce the issue:

  1. minikube start --download-only --image-repository=docker.artifactory.example.com
  2. Containers are (mostly, see linked issue) downloaded, but it times out downloading kubelet, etc.

There is obviously the --image-repository option already, as well as the --iso-url option that could be used to point to an alternative location for the minikube ISO (I don't need/use that particular option), so it seems odd that there's no way to specify an alternative location for the remaining kube* binaries.

@RA489
Copy link

RA489 commented Jul 12, 2021

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Jul 12, 2021
@bodgit
Copy link
Contributor Author

bodgit commented Jul 12, 2021

This is where the binary URLs are constructed:

base := fmt.Sprintf("https://storage.googleapis.com/kubernetes-release/release/%s/bin/%s/%s/%s", version, osName, archName, binaryName)

@sharifelgamal sharifelgamal added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed kind/support Categorizes issue or PR as a support question. labels Aug 11, 2021
@sharifelgamal
Copy link
Collaborator

I think this is a great idea!

@sharifelgamal sharifelgamal added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 11, 2021
@presztak
Copy link
Member

Hi, I'd like to work on this issue.
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
5 participants