Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting file mounting with--no-kubernetes flag #13003

Closed
spowelljr opened this issue Nov 22, 2021 · 1 comment · Fixed by #13144
Closed

Supporting file mounting with--no-kubernetes flag #13003

spowelljr opened this issue Nov 22, 2021 · 1 comment · Fixed by #13144
Assignees
@spowelljr
Labels
area/mount kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
1.25.0

Comments

@spowelljr
Copy link
Member

Currently, if the --no-kubernetes flag is passed, mounting is skipped, but users still want to be able to mount files with --no-kubernetes so we should not skip it.
@spowelljr spowelljr added area/mount kind/improvement Categorizes issue or PR as related to improving upon a current feature. labels Nov 22, 2021
@spowelljr spowelljr added this to the 1.25.0 milestone Nov 22, 2021
@spowelljr spowelljr self-assigned this Nov 22, 2021
@spowelljr spowelljr added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 22, 2021
@spowelljr
Copy link
Member Author

Change is done, waiting for #12930 to be merged first since it changes mount func signature.

@spowelljr spowelljr mentioned this issue Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spowelljr spowelljr

Labels
area/mount kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging a pull request may close this issue.

Support mounting with the --no-kubernetes flag spowelljr/minikube
1 participant
@spowelljr