Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSH completion #1794

Closed
vainikkaj opened this issue Aug 6, 2017 · 3 comments
Closed

ZSH completion #1794

vainikkaj opened this issue Aug 6, 2017 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vainikkaj
Copy link

vainikkaj commented Aug 6, 2017

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Minikube version (use minikube version): v0.20.0

Environment:

  • OS (e.g. from /etc/os-release): 16.04.3 LTS (Xenial Xerus)
  • VM Driver (e.g. cat ~/.minikube/machines/minikube/config.json | grep DriverName): virtualbox
  • ISO version (e.g. cat ~/.minikube/machines/minikube/config.json | grep -i ISO or minikube ssh cat /etc/VERSION): minikube-v0.20.0.iso
  • Install tools: ZSH

Cobra now has command hiearchy completion for ZSH in master. See spf13/cobra/pull/497
Even though it is still missing more advanced stuff, basic command compeletion for ZSH would be very useful.

@r2d4 r2d4 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2017
@r2d4
Copy link
Contributor

r2d4 commented Aug 10, 2017

Yup this would be cool. Even though we use cobra in minikube, we track the version from upstream kubernetes . So we'll have to wait until its updated upstream, so we avoid vendor merge conflicts all the time.

@msogrin
Copy link

msogrin commented Aug 14, 2017

Minikube ZSH completion is already implemented in https://github.com/zchee/go-zsh-completions/blob/master/src/_minikube, but it would have been useful to bring that work into Minikube itself.

@kenden
Copy link
Contributor

kenden commented Nov 21, 2017

It's in master, will be in the next release.
Related, easy way to enable the completion: ohmyzsh/ohmyzsh#6436

@r2d4 r2d4 closed this as completed Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants