Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit 7a9f3be reverted vendor change of PR 1798 #2007

Closed
huguesalary opened this issue Sep 26, 2017 · 6 comments
Closed

Commit 7a9f3be reverted vendor change of PR 1798 #2007

huguesalary opened this issue Sep 26, 2017 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@huguesalary
Copy link
Contributor

huguesalary commented Sep 26, 2017 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

PR #1881 just canceled PR #1798

That is, PR #1798 updated the vendored github.com/spf13/viper from revision 7fb2782df3d83e0036cc89f461ed0422628776f4 to 25b30aa063fc18e48662b86996252eabdcf2f0c7, to fix a bug reported in #1797

PR #1881 just reverted back to 7fb2782df3d83e0036cc89f461ed0422628776f4
@huguesalary
Copy link
Contributor Author

huguesalary commented Sep 26, 2017 •
edited
Loading

Actually, PR #1881 is not the problematic commit.

Commit 7a9f3bef0d49ec8747e699e82327500f94ed3aa3 (Upgrade to Kubernetes v1.7.5) is the issue.

@huguesalary huguesalary changed the title PR 1881 reverted vendor change of PR 1798 Commit 7a9f3bef0d49ec8747e699e82327500f94ed3aa3 reverted vendor change of PR 1798 Sep 26, 2017
@huguesalary huguesalary changed the title Commit 7a9f3bef0d49ec8747e699e82327500f94ed3aa3 reverted vendor change of PR 1798 Commit 7a9f3be reverted vendor change of PR 1798 Sep 26, 2017
@r2d4
Copy link
Contributor

r2d4 commented Sep 26, 2017

This is due to the script which prioritizes upstream kubernetes/kubernetes dependencies over ours in the case of a conflict. We'll need to add a step to the restore script to make sure we still checkout the correct version of viper.

https://github.com/kubernetes/minikube/blob/master/hack/godeps/godep-restore.sh

@huguesalary
Copy link
Contributor Author

Cool that's good to know.

I'd help modifying this script, but I'm not sure what I'd need to do.

@r2d4 r2d4 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 27, 2017
@huguesalary huguesalary mentioned this issue Dec 5, 2017
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 5, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 5, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@huguesalary @r2d4 @k8s-ci-robot @fejta-bot