Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube docker-env writes error to stdout if VM isn't running - confuses shell #3311

Closed
misha-ridge opened this issue Nov 7, 2018 · 5 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@misha-ridge
Copy link

Environment:

Minikube version: 0.30

  • OS (e.g. from /etc/os-release): macOS 10.13
  • VM Driver: VirtualBox
  • ISO version: N/A
  • Install tools:
  • Others:

What happened:

% eval $(minikube docker-env)
E1107 17:14:21.381360    3836 env.go:330] Error setting machine env variable(s): Error getting ip from host: Host is not running
zsh: =============================================================================== not found

What you expected to happen:

If a Minikube VM is not running, eval $(minikube docker-env) should fail, but not in such a confusing way, with shell trying to execute a command ===============================================================================.

How to reproduce it (as minimally and precisely as possible):

Stop the Minikube VM. Run eval $(minikube docker-env)

@tstromberg
Copy link
Contributor

Sorry - minikube shouldn't be doing this. I wasn't able to replicate the issue, so do you mind supplying some more details?

I'd be curious about the output of minikube docker-env and minikube status that you are seeing.

@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. os/macos co/virtualbox labels Nov 7, 2018
@misha-ridge
Copy link
Author

% minikube status
minikube: Stopped
cluster:
kubectl:
% minikube docker-env
E1108 17:10:20.272974   76458 env.go:330] Error setting machine env variable(s): Error getting ip from host: Host is not running
================================================================================
An error has occurred. Would you like to opt in to sending anonymized crash
information to minikube to help prevent future errors?
To opt out of these messages, run the command:
	minikube config set WantReportErrorPrompt false
================================================================================
Please enter your response [Y/n]: n

@misha-ridge
Copy link
Author

And indeed the crash reporter prints to stdout.

@tstromberg tstromberg changed the title minikube docker-env should not write anything to stdout if the VM is not running, it confuses shell minikube docker-env writes error to stdout if VM isn't running - confuses shell Jan 23, 2019
@tstromberg tstromberg added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed co/virtualbox os/macos labels Jan 23, 2019
@tstromberg
Copy link
Contributor

That sounds reasonable. I'd be happy to review any PR's or help anyone interested in addressing this bug.

@tstromberg
Copy link
Contributor

Fixed in v0.34.0. You may want to be aware of #3697 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

2 participants