Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring REGISTRY_STORAGE_DELETE_ENABLED for the registry addon #4044

Closed
carroarmato0 opened this issue Apr 3, 2019 · 4 comments
Closed

Allow configuring REGISTRY_STORAGE_DELETE_ENABLED for the registry addon #4044

carroarmato0 opened this issue Apr 3, 2019 · 4 comments
Labels
area/registry registry related issues good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. r/2019q2 Issue was last reviewed 2019q2

Comments

@carroarmato0
Copy link

When enabling the Registry Addon, a docker registry is created in the cluster with defaults.

The defaults allow a user to push images to the private registry, not removing them.

The registry container needs to be spun up with the following environment variable:

REGISTRY_STORAGE_DELETE_ENABLED=true

Proposal
Allow configuring the option similarly to how the registry-creds can be configured.
@balopat balopat added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 4, 2019
@balopat
Copy link
Contributor

balopat commented Apr 4, 2019

Thanks for filing this! It sounds completely reasonable to me.

@balopat balopat added addon/registry-creds registry-creds issues area/registry registry related issues good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed addon/registry-creds registry-creds issues labels Apr 4, 2019
@hpandeycodeit hpandeycodeit mentioned this issue Apr 11, 2019
Merged
@tstromberg tstromberg added the r/2019q2 Issue was last reviewed 2019q2 label May 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@tstromberg
Copy link
Contributor

This was fixed in v1.4. REGISTRY_STORAGE_DELETE_ENABLED=true is now the default.

@JohnGalt1717
Copy link

I wouldn't call this fixed. Now the default behavior is that on every restart of the computer the registry is empty

We need to be able configure this at the command line and configure a path for the volume mount for the storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/registry registry related issues good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. r/2019q2 Issue was last reviewed 2019q2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tstromberg @balopat @carroarmato0 @JohnGalt1717 @k8s-ci-robot @fejta-bot