Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon manager presumes port 8443 -- fails when used with different --apiserver-port #4384

Closed
moduspwnens opened this issue May 30, 2019 · 1 comment
Closed

Addon manager presumes port 8443 -- fails when used with different --apiserver-port #4384

moduspwnens opened this issue May 30, 2019 · 1 comment
Labels
area/addons kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@moduspwnens
Copy link
Contributor

moduspwnens commented May 30, 2019 •
edited
Loading

If minikube is started with the --apiserver-port directive set to a non-default value, the addon-manager pod fails to connect to the apiserver.

The culprit seems to be a hardcoding of port 8443 here:

minikube/pkg/minikube/bootstrapper/certs.go

Line 69 in 8ba53c6

ClusterServerAddress: "https://localhost:8443",

The fix is a one-liner--I'll submit a pull request.
@tstromberg
Copy link
Contributor

Oof. Good find! I'm looking forward to the PR for this.

@tstromberg tstromberg added area/addons kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. labels May 30, 2019
@moduspwnens moduspwnens mentioned this issue May 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addons kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tstromberg @moduspwnens