Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete profile should Unset the current profile #4891

Closed
medyagh opened this issue Jul 27, 2019 · 1 comment · Fixed by #4922
Closed

Delete profile should Unset the current profile #4891

medyagh opened this issue Jul 27, 2019 · 1 comment · Fixed by #4922
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Jul 27, 2019

Delete profile should Unset the current profile

to reproduce:
1- create a minikube with profile p1 and p2

./out/minikube start -p p1 --vm-driver=hyperkit
./out/minikube start -p p2 --vm-driver=hyperkit

2- set the current profile to p1

./out/minikube profile p1

3- delete profile p1

 ./out/minikube delete -p p1
🔥  Deleting "p1" in hyperkit ...
💔  The "p1" cluster has been deleted.

4-
the current profile is gone from profile list (correctly) however if u check for current profile it shows the deleted one:

medya@ ~/workspace/ppl-minikube (fix-glog-parse-error) $ ./out/minikube profile list
|----------|-----------|----------------|-----------|--------------------|
| Profile  | VM Driver |     NodeIP     | Node Port | Kubernetes Version |
|----------|-----------|----------------|-----------|--------------------|
| minikube | hyperkit  | 192.168.64.102 |      8443 | v1.15.0            |
| p3       | hyperkit  | 192.168.64.118 |      8443 | v1.15.0            |
|----------|-----------|----------------|-----------|--------------------|

5- check for current profile

$ ./out/minikube profile
p1

The fix should, after delete unset the current config.

@medyagh medyagh added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 27, 2019
@josedonizetti
Copy link
Member

/assign @josedonizetti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants