Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss: minikube wait for default service accont ? #7011

Closed
medyagh opened this issue Mar 11, 2020 · 0 comments · Fixed by #7375
Closed

discuss: minikube wait for default service accont ? #7011

medyagh opened this issue Mar 11, 2020 · 0 comments · Fixed by #7375
Labels
kind/process Process oriented issues, like setting up CI priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 11, 2020

as part of this PR #6999 to close #6997

I added wait for default service account to be created before the integeration tests apply yaml files.
at first I wanted to add that to minikube itself but that added 30 seconds to minikube start on my machine. and this would add very little value to 90% of the people.
even in our high stress integeration test it is a flake behavior, that sometimes we get this errr described here #6997

we could do one these, so neither the kabab be burnt nor the skewer. (persian slang) :

option 1 switch default behaviour

we can make the current wait=true behaviour to be called wait=false (do current wait behaviour even if user dosnt wanna wait)
and make wait=false the default behavior
and then for wait=true we add waiting for default service account.
that would make minikube more usable in testing environments.

option 2 add a new flag, get list of componenets to wait for

we add another flag, that gets a list of things that user wants us to wait for
--wait-for: [comp1, comp2, comp3]

like
--wait-for=apiserver,default-service-account
--wait-for=all

option 3 change the current flag from boolean to list

--wait
with a default value of the current things we wait for
apiserver,.systempods...

and we should handle logic that if user provided true or false, we should translate that for backward comaptibility

but if user wanted to they could add more to the list
--wait=all
ot
--wait=apiserver,systempods,default_sa ...

This seems to be covering up an actual flaw that users can face. Shouldn't the start command wait for this?

Originally posted by @tstromberg in https://github.com/kubernetes/minikube/pull/6999/files

@medyagh medyagh added the triage/discuss Items for discussion label Mar 11, 2020
@tstromberg tstromberg added kind/process Process oriented issues, like setting up CI priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 19, 2020
@tstromberg tstromberg removed the triage/discuss Items for discussion label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/process Process oriented issues, like setting up CI priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants