Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kube-webhook-certgen image 1.2.0 -> 1.2.2 in deploy.yaml #8636

Closed
sid226 opened this issue Jul 3, 2020 · 3 comments · Fixed by #8705
Closed

update kube-webhook-certgen image 1.2.0 -> 1.2.2 in deploy.yaml #8636

sid226 opened this issue Jul 3, 2020 · 3 comments · Fixed by #8705
Assignees
@hjmodi
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@sid226
Copy link

sid226 commented Jul 3, 2020

Need to update kube-webhook-certgen image 1.2.0. -> 1.2.2 in ingress-dp.yaml.tmpl
https://github.com/kubernetes/minikube/tree/master/deploy/addons/ingress

kube-webhook-certgen has been updated recently to 1.2.2 for adding s390x support.

jet/kube-webhook-certgen#15

https://hub.docker.com/r/jettech/kube-webhook-certgen/tags

as per steps given here :
https://kubernetes.github.io/ingress-nginx/deploy/
@medyagh
Copy link
Member

medyagh commented Jul 7, 2020

@sid226 thank you for making this issue, I would be happy to review any Pr that bumps the version for ingress addon

@medyagh medyagh added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 7, 2020
@sid226
Copy link
Author

sid226 commented Jul 8, 2020

@medyagh If possible, nginx-ingress image also can be bumped to 0.33.0

http://quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.33.0

This was referenced Jul 10, 2020
Closed
Closed
@hjmodi
Copy link
Contributor

hjmodi commented Jul 12, 2020

/assign

@hjmodi hjmodi mentioned this issue Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjmodi hjmodi

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
3 participants
@medyagh @hjmodi @sid226