Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more descriptive error codes for GUEST_PROVISIONG #9907

Closed
nelango opened this issue Dec 10, 2020 · 6 comments · Fixed by #11301
Closed

Provide more descriptive error codes for GUEST_PROVISIONG #9907

nelango opened this issue Dec 10, 2020 · 6 comments · Fixed by #11301
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers
Milestone

Comments

@nelango
Copy link

nelango commented Dec 10, 2020

GUEST_PROVISION comprises 8.5% of minikube start errors in our environment.

These could be because minikube failed to obtain driver options/ generate cluster config/ cache minikube ISO.

Can minikube provide more descriptive error codes for their scenarios? It would also help to make the error messages actionable wherever possible.

@tstromberg
Copy link
Contributor

As a catchall error code, In order to break this code down further, we'll need to collect example error messages for known issues. We can then add support for them here:

https://github.com/kubernetes/minikube/blob/master/pkg/minikube/reason/known_issues.go

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. ux/embedded Embedded UX blockers priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 14, 2020
@tstromberg
Copy link
Contributor

Here's the best advice I have for collecting this info:

https://github.com/kubernetes/minikube/issues?q=is%3Aissue+GUEST_PROVISION

Looks like we have 21 examples currently that can get broken down to more specific exit codes.

@tstromberg tstromberg added this to the v1.17.0-candidate milestone Jan 7, 2021
@tstromberg
Copy link
Contributor

tstromberg commented Jan 22, 2021

I noticed at least one bug here in #10151 - it should have raised PR_DOCKER_NO_SSH instead of GUEST_PROVISION. This makes me wonder if there is a bug that is causing known_issues to not be parsed.

UPDATE: I misread the text, the two errors are very similar, but not identical.

@azhao155
Copy link
Contributor

azhao155 commented Feb 8, 2021

/assign @azhao155

@medyagh
Copy link
Member

medyagh commented Mar 2, 2021

@azhao155 has too many tasks this milestone, I unassign it for now if anyone wants to pick it up

@spowelljr
Copy link
Member

In-progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants