From 649b8ef5b1137a50dd4c0d24982284b96f965e61 Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Wed, 28 Dec 2022 08:42:01 -0800 Subject: [PATCH 1/2] remove experimental markings from QEMU driver --- pkg/minikube/registry/drvs/qemu2/qemu2.go | 2 +- site/content/en/docs/drivers/_index.md | 4 ++-- site/content/en/docs/drivers/qemu.md | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/minikube/registry/drvs/qemu2/qemu2.go b/pkg/minikube/registry/drvs/qemu2/qemu2.go index d5264136c402..f12a44cb2158 100644 --- a/pkg/minikube/registry/drvs/qemu2/qemu2.go +++ b/pkg/minikube/registry/drvs/qemu2/qemu2.go @@ -48,7 +48,7 @@ func init() { Config: configure, Status: status, Default: true, - Priority: registry.Experimental, + Priority: registry.Preferred, }); err != nil { panic(fmt.Sprintf("register failed: %v", err)) } diff --git a/site/content/en/docs/drivers/_index.md b/site/content/en/docs/drivers/_index.md index 6744c03ff377..7f9aacda7778 100644 --- a/site/content/en/docs/drivers/_index.md +++ b/site/content/en/docs/drivers/_index.md @@ -17,7 +17,7 @@ To do so, we use the [Docker Machine](https://github.com/docker/machine) library * [Docker]({{}}) - container-based (preferred) * [KVM2]({{}}) - VM-based (preferred) * [VirtualBox]({{}}) - VM -* [QEMU]({{}}) - VM (experimental) +* [QEMU]({{}}) - VM * [None]({{}}) - bare-metal * [Podman]({{}}) - container (experimental) * [SSH]({{}}) - remote ssh @@ -30,7 +30,7 @@ To do so, we use the [Docker Machine](https://github.com/docker/machine) library * [VirtualBox]({{}}) - VM * [Parallels]({{}}) - VM * [VMware Fusion]({{}}) - VM -* [QEMU]({{}}) - VM (experimental) +* [QEMU]({{}}) - VM * [SSH]({{}}) - remote ssh ## Windows diff --git a/site/content/en/docs/drivers/qemu.md b/site/content/en/docs/drivers/qemu.md index 7aa926d94edd..c1b1fe8f58d0 100644 --- a/site/content/en/docs/drivers/qemu.md +++ b/site/content/en/docs/drivers/qemu.md @@ -34,10 +34,7 @@ minikube start supports some qemu specific flags: The QEMU driver has two networking options, `user` & `socket_vmnet`. {{% tabs %}} -{{% tab "user - limited functionality" %}} -The `user` network is not a dedicated network, it doesn't support some networking commands such as `minikube service` and `minikube tunnel`, and its IP address is not reachable from the host. -{{% /tab %}} -{{% tab "socket_vmnet - experimental/needs installation" %}} +{{% tab "socket_vmnet - needs installation" %}} ### Requirements @@ -57,6 +54,9 @@ minikube start --driver qemu --network socket_vmnet The `socket_vmnet` network is a dedicated network and supports the `minikube service` and `minikube tunnel` commands. {{% /tab %}} +{{% tab "user - limited functionality" %}} +The `user` network is not a dedicated network, it doesn't support some networking commands such as `minikube service` and `minikube tunnel`, and its IP address is not reachable from the host. +{{% /tab %}} {{% /tabs %}} ## Known Issues From f4e0de7c2685c8a8e45f58fd2379c251674f8178 Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Wed, 4 Jan 2023 08:30:09 -0800 Subject: [PATCH 2/2] change priority to default --- pkg/minikube/registry/drvs/qemu2/qemu2.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/minikube/registry/drvs/qemu2/qemu2.go b/pkg/minikube/registry/drvs/qemu2/qemu2.go index f12a44cb2158..cb16192d0890 100644 --- a/pkg/minikube/registry/drvs/qemu2/qemu2.go +++ b/pkg/minikube/registry/drvs/qemu2/qemu2.go @@ -48,7 +48,7 @@ func init() { Config: configure, Status: status, Default: true, - Priority: registry.Preferred, + Priority: registry.Default, }); err != nil { panic(fmt.Sprintf("register failed: %v", err)) }