Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Installing kubeadm” recommends downloads from non-canonical (?) URLs #33228

Closed
sftim opened this issue Apr 26, 2022 · 6 comments · Fixed by #34425
Closed

“Installing kubeadm” recommends downloads from non-canonical (?) URLs #33228

sftim opened this issue Apr 26, 2022 · 6 comments · Fixed by #34425
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Apr 26, 2022

This is a Bug Report

Problem:
The “without a package manager” section of Installing kubeadm suggests that people download components from within https://storage.googleapis.com/kubernetes-release/release/

However, https://www.downloadkubernetes.com/ recommends downloading from https://dl.k8s.io/

To me, the https://dl.k8s.io/ URLs seem more official and also make it easier for us to bolt in a CDN or whatever if we want to serve content from not-Google.

Proposed Solution:

  • Revise the “without a package manager” tab in Installing kubeadm to recommend downloading kubeadm and kubelet from https://dl.k8s.io/
    • If possible, avoid fetching the latest release version via HTTP.
      This website repo already has the release information available so we can cut out a step (and make the docs more accurate when people are reading docs for previous Kubernetes versions).
  • For the kubectl download, refer readers to https://kubernetes.io/docs/tasks/tools/#kubectl
  • Continue to recommend downloading crictl from GitHub
  • Continue to recommend downloading CNI tooling from GitHub

Page to Update:
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/

Additional Information:
The same page also recommends downloading packages (RPM, .deb) from Google. This issue doesn't cover the packaged downloads, just the direct downloads of the files.
This issue also doesn't cover a change to how people download crictl and install that tool.
This issue also doesn't cover a change to how people download CNI tooling.

/sig release
/sig cluster-lifecycle
/language en

@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Apr 26, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 26, 2022
@shannonxtreme
Copy link
Contributor

If we remove the RELEASE version fetch step, we'd need a step to choose a Kubernetes version right? So something like "Choose the Kubernetes version you want to install from the Releases page."

And then another line in the actual command that downloads kubeadm and the rest that says "Replace $RELEASE with the Kubernetes version that you selected".

Am I off track here?

also

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 26, 2022
@sftim
Copy link
Contributor Author

sftim commented Apr 27, 2022

You can already choose which Kubernetes version you're reading the docs for, so it ought to be enough to signpost readers to the choice.

To help readers, we can also link from https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/ to the same doc in each of the supported docs versions - I think that'd need a shortcode, but it could be done.

@sftim
Copy link
Contributor Author

sftim commented Apr 27, 2022

For example, https://v1-21.docs.kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/ could explain how to install kubeadm v1.21.x (whatever is latest for v1.21).

@sftim
Copy link
Contributor Author

sftim commented May 8, 2022

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label May 8, 2022
@Rishit-dagli
Copy link
Member

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
5 participants