Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature blog 1.30: user namespaces #45354

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Feature blog 1.30: user namespaces #45354

merged 1 commit into from
Apr 20, 2024

Conversation

rata
Copy link
Member

@rata rata commented Feb 26, 2024 •
edited
Loading

Blog post about user namespace migrating to beta in 1.30.

cc @giuseppe

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 33ef483
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/661678398cbb460008479991

@rata rata mentioned this pull request Feb 26, 2024
Open
26 tasks
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Feb 26, 2024
@windsonsea
Copy link
Member

You can mark it as a draft for clarity.

image

@rata rata marked this pull request as draft February 27, 2024 14:31
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@Checksumz
Copy link
Contributor

Checksumz commented Mar 12, 2024 •
edited
Loading

howdy @rata, I am your assigned 1.30 Release comms shadow and was hoping to help you along with deadlines for this blog. It looks like it is currently a work in progress.
The Ready for Review deadline is March 22, 2024. As we have few blog reviewers, we want to make sure you have ample time to get your content together. Please let me know how we can help!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
@rata rata marked this pull request as ready for review March 12, 2024 16:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@rata
Copy link
Member Author

rata commented Mar 12, 2024 •
edited
Loading

@Checksumz thanks! This is ready for review

@rata rata force-pushed the rata/blog-userns-1.30 branch 2 times, most recently from b11e77c to 0931de4 Compare March 12, 2024 17:02
@rata
Copy link
Member Author

rata commented Apr 10, 2024

@nate-double-u @Checksumz thanks, applied all the suggestions. PTAL! :)

@Checksumz
Copy link
Contributor

Checksumz commented Apr 10, 2024 •
edited
Loading

@nate-double-u @Checksumz thanks, applied all the suggestions. PTAL! :)

Thank you @rata.
@nate-double-u the changes you recommended have been applied, please can you review and approve if everything looks good.

@reylejano
Copy link
Member

If this blog PR is to be merged after the 1.30 release, this should target the main branch as the dev-1.30 branch would be merged into main on the 1.30 release day. Any updates to the dev-1.30 branch post 1.30 release won't be sync'd with main

@rata rata changed the base branch from dev-1.30 to main April 11, 2024 19:56
@rata
Copy link
Member Author

rata commented Apr 11, 2024

@reylejano thanks for catching that, this is based on (and against) main now.

@rata
Copy link
Member Author

rata commented Apr 11, 2024

It's 9pm here and I'm about to leave, if more changes are needed I hope @giuseppe or @saschagrunert can do them while I'm away in the next few days.

@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 052cf7e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/661f683689da3c0008b4e944
😎 Deploy Preview https://deploy-preview-45354--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gauravpadam
Copy link
Member

I have some bandwidth today, I'll be reviewing

@Checksumz
Copy link
Contributor

/lgtm
@mrbobbytables please can you review and approve this PR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dd88c5ff781a7332470cb5701d20141ce13ac565

sftim
sftim reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

🛑 Do not merge until Kubernetes v1.30 is released 🛑

content/en/blog/_posts/2024-04-22-userns-beta/index.md Outdated
the exploit, which works without user namespaces, **is mitigated when user
namespaces are in use.**

{{< youtube id="07y5bl5UDdA" title="Mitigation of CVE-2024-21626 on Kubernetes by enabling User Namespace">}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit large, and title title is slightly off

Suggested change
{{< youtube id="07y5bl5UDdA" title="Mitigation of CVE-2024-21626 on Kubernetes by enabling User Namespace">}}
{{< youtube id="07y5bl5UDdA" title="Mitigation of CVE-2024-21626 on Kubernetes by enabling User Namespace support" class="youtube-quote-sm" >}}

What I recommend: leave this as-is until the release day, then once this has merged (even before publication), send in a follow-up PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit large, and title title is slightly off

What I recommend: leave this as-is until the release day, then once this has merged (even before publication), send in a follow-up PR.

Hi @giuseppe & @saschagrunert, since @rata is on holidays will you be able to address this suggestion ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the suggestion. 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx, mrunalp, saschagrunert, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@rata @saschagrunert
blog: Add userns feature post for 1.30
052cf7e 
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2024
@sftim
Copy link
Contributor

sftim commented Apr 17, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 023983989293b510eadbd89edf49d3d3b395dca5

@kcmartin
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 08c5377 into kubernetes:main Apr 20, 2024
6 checks passed
@sftim sftim mentioned this pull request Apr 22, 2024
Closed
@rata rata deleted the rata/blog-userns-1.30 branch April 29, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u left review comments

@kcmartin kcmartin kcmartin left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mrunalp mrunalp mrunalp approved these changes

@natalisucks natalisucks Awaiting requested review from natalisucks

@windsonsea windsonsea Awaiting requested review from windsonsea

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@matthyx matthyx Awaiting requested review from matthyx

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@Checksumz Checksumz Awaiting requested review from Checksumz

@sftim sftim Awaiting requested review from sftim

Assignees

@saschagrunert saschagrunert

@mrbobbytables mrbobbytables

@Checksumz Checksumz

@matthyx matthyx

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.